[PATCH] D78045: [XCOFF][AIX] Fix getSymbol to return the correct qualname when necessary

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a comment.

I think this is pretty much there. It is important enough that I'd want explicit approval from another one of the reviewers as well though.



================
Comment at: llvm/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h:267
+
+  MCSymbol *getTargetSymbol(const GlobalValue *GV,
+                            const TargetMachine &TM) const override;
----------------
Comments about function descriptor versus entry point would go here?


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1889
+  // We always use a qualname symbol for a GV that represents
+  // a declaration, a function descriptor, or a common symbol.
+  if (const GlobalObject *GO = dyn_cast<GlobalObject>(GV)) {
----------------
Comment goes here to clarify that a `GV` representing the address of a function is inherently ambiguous between representing a function descriptor and a function entry point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78045/new/

https://reviews.llvm.org/D78045