[PATCH] D72959: Relative VTables ABI on Fuchsia

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: clang/include/clang/Basic/LangOptions.def:353
 COMPATIBLE_VALUE_LANGOPT(MaxTokens, 32, 0, "Max number of tokens per TU or 0")
+LANGOPT(FuchsiaRelativeCXXABIVTables, 1, 0,
+        "Whether to use clang's relative C++ ABI "
----------------
I think we should omit the `Fuchsia` bit and make it a generic, this feature should be usable by any target.


================
Comment at: clang/include/clang/Driver/Options.td:1328
 
+def fexperimental_fuchsia_relative_cxx_abi_vtables : Flag<["-"], "fexperimental-fuchsia-relative-c++-abi-vtables">,
+  Group<f_Group>, Flags<[CC1Option]>,
----------------
Ditto, I'd drop the `fuchsia` bit from these flags.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72959/new/

https://reviews.llvm.org/D72959