[PATCH] D77242: [CommandLine] Fix cl::ConsumeAfter support with more than one positional argument

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

ConsumeAfter is used in three places: lli, KillTheDoctor, and modularize, so I wouldn't be surprised if there was an off-by-one error here.

Starting the index here at 1 dates back to the original CommandLine 2.0 check in (rG5df56c47fc5c <https://reviews.llvm.org/rG5df56c47fc5c5b7193d36d4987bc17a3e9a00e47>), so I'm hesitant to say this is correct, but your unit tests and the lit suite for lli give me confidence that it does. Looks good to me, I guess.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77242/new/

https://reviews.llvm.org/D77242