[PATCH] D78224: ValueLattice, LVI, SCCP: Use floating point constant ranges

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 15 12:36:49 PDT 2020


fhahn added a reviewer: fhahn.
fhahn added a comment.

Very interesting! On a high-level, it would probably be good to split those changes into 3 (ValueLattice, LVI & SCCP); not sure how tricky that's going to be given adding automatic support in markConstant & co. If it's too tricky splitting LVI & SCCP would be great.

Also, the existing tests cover very little floating point stuff, at least for SCCP (and probably LVI too), It would be good to add FP versions of llvm/tests/Transforms/{ip-ranges-binaryops.ll,  ip-ranges-casts.ll, ip-ranges-select.ll ip-constant-ranges.ll, conditions-ranges.ll, conditions-ranges-with-undef.ll} for example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78224/new/

https://reviews.llvm.org/D78224





More information about the llvm-commits mailing list