[PATCH] D78226: [MLIR] Improve support for 0-dimensional Affine Maps.

Alex Zinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 15 12:36:48 PDT 2020


ftynse accepted this revision.
ftynse added inline comments.


================
Comment at: mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:527
+  for (auto exprs : reassociation) {
+    assert(exprs.size() != 0);
+    maps.push_back(AffineMap::get(maxDim + 1, 0, exprs, exprs[0].getContext()));
----------------
Nit: consider adding a message to the assertion, as in `assert(condition && "message")`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78226/new/

https://reviews.llvm.org/D78226





More information about the llvm-commits mailing list