[PATCH] D78173: MachineFunctionInfo for AArch64 in MIR

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/function-info-noredzone-present.ll:9
+    ; CHECK-LABEL: name:            baz
+    ; CHECK-LABEL: machineFunctionInfo: {}
+    ret void
----------------
This shouldn't use `CHECK-LABEL`, just the first one.

`CHECK-LABEL` divides the input stream up into blocks. So, for example

```
; CHECK-LABEL: foo
; CHECK: something

; CHECK-LABEL: bar
; CHECK: thingsome
...
```

After matching `foo`, we'll try to match `something` at some point in the file after `foo`.

We won't match lines after matching `bar` though, because it has a `CHECK-LABEL` check line. So, it's not in the same block. As a result of this, if someone introduced a bug that made `thingsome` into `something`, we wouldn't accidentally match it after `foo`.

https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-label-directive


================
Comment at: llvm/test/CodeGen/MIR/AArch64/function-info-noredzone-present.mir:7
+# CHECK-NAME: name:            foo
+# CHECK-LABEL: machineFunctionInfo: {}
+
----------------
Same as above, we want the `CHECK-LABEL` to be on `foo`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78173/new/

https://reviews.llvm.org/D78173