[PATCH] D78220: IR/ConstantRange: Add support for FP ranges

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 15 11:30:33 PDT 2020


nikic added a comment.

I would strongly recommend to implement this as a separate type (FloatRange for example), rather than combining it into ConstantRange. There's a couple reasons for that, the main ones would be a) float ranges have significantly different semantics, in particular the fact that they are inclusive and b) ConstantRange is a size critical structure, because it is used in value lattice elements. As implement, this change is going to skyrocket memory consumption during SCCP.

It would also be nice to have some general context on where you plan to use this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78220/new/

https://reviews.llvm.org/D78220





More information about the llvm-commits mailing list