[PATCH] D78044: [mlir][ods] Update doc regarding attribute definitions

Jacques Pienaar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 15 10:57:07 PDT 2020


jpienaar accepted this revision.
jpienaar added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: mlir/docs/OpDefinitions.md:1040
+
+*   `DefaultValuedAttr`: decorates an attribute with a default value. See
+    [attributes with default values](#attributes-with-default-values) for
----------------
Nit: but with these it seems we are duplicating ourselves, how about just

* `DefaultValueAttr`: specifies the [default value of an attribute](...).
...

folks can see the link and click if they want to find out more (meaning, I see a link as implicitly meaning "go here to find more info" and so don't need to spell it out).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78044/new/

https://reviews.llvm.org/D78044





More information about the llvm-commits mailing list