[PATCH] D75567: [x86] Enable bypassing 64-bit division on generic x86-64

Wed Apr 15 10:57:03 PDT 2020

RKSimon added a comment.

In D75567#1959903 <https://reviews.llvm.org/D75567#1959903>, @atdt wrote:

> In D75567#1959215 <https://reviews.llvm.org/D75567#1959215>, @RKSimon wrote:
>
> > Test cases?
>
>
> I'm not sure what kind of test case to add. The codegen tests for bypassing slow division <https://github.com/llvm/llvm-project/blob/7bb433c87b602a181a9e6ee08e38717a63b6f478/llvm/test/CodeGen/X86/bypass-slow-division-64.ll#L3> use `-mattr=[+-]idivq-to-divl` to explicitly control this feature, rather than assume it is enabled or disabled for a particular target.

In which case we probably just need to add an additional -mcpu=x86-64 test to bypass-slow-division-tune.ll ?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75567/new/

https://reviews.llvm.org/D75567