[PATCH] D77844: [ObjectYAML][MachO] Add support for relocations

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap marked an inline comment as done.
alexshap added inline comments.


================
Comment at: llvm/include/llvm/ObjectYAML/MachOYAML.h:32
+  // Offset in the section to what is being relocated.
+  llvm::yaml::Hex32 address;
+  // Symbol index if r_extern == 1 else section index.
----------------
grimar wrote:
> Should it be called `offset`?
@grimar -  I agree, however, the rationale here was to reuse the existing names, even though they are awful, to avoid causing further pain when people try to match different structures from different codebases.

http://llvm.org/doxygen/MachORelocation_8h_source.html 
https://opensource.apple.com/source/cctools/cctools-949.0.1/include/mach-o/reloc.h.auto.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77844/new/

https://reviews.llvm.org/D77844