[PATCH] D78195: [MLIR] Add IndexAttr to primitive attributes kinds in tablegen.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 15 10:24:14 PDT 2020


rriddle added inline comments.


================
Comment at: mlir/test/IR/attribute.mlir:11
     any_i32_attr = 5 : ui32,
+    // CHECK-SAME: index_attr = 8 : index
+    index_attr = 8 : index,
----------------
This doesn't test anything added here. You need to add IndexAttr to the definition of int_attrs(IntAttrOp) in TestOps.td.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78195/new/

https://reviews.llvm.org/D78195





More information about the llvm-commits mailing list