[PATCH] D78202: [FileCheck] - Refactor the code related to string arrays. NFCI.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

I am a bit concerned that the storage of these std::string's are in `cl::list<string>`, and it is not entirely clear that the StringRef's will not get invalidated.

Other cleanups, look good, though.

- `auto -> concrete type`
- `emplace_back(std::string(...))` -> `emplace_back(...)`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78202/new/

https://reviews.llvm.org/D78202