[PATCH] D78191: [GlobalISel] Fix invalid combine of unmerge(merge) with intermediate cast

[Dominik Montada via Phabricator via llvm-commits]

gargaroff updated this revision to Diff 257713.
gargaroff marked 4 inline comments as done.
gargaroff added a comment.

move legality check to canFoldMergeOpcode

use difference source and destination registers in tests

remove error check from xfail test, only expect crash


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78191/new/

https://reviews.llvm.org/D78191

Files:
  llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h
  llvm/test/CodeGen/AMDGPU/GlobalISel/artifact-combiner-unmerge-values.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/cvt_f32_ubyte-xfail.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/cvt_f32_ubyte.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-bitcast.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-merge-values.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-unmerge-values.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/zextload-xfail.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/zextload.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78191.257713.patch
Type: text/x-patch
Size: 149958 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200415/35de6f22/attachment-0001.bin>