[PATCH] D76210: [Attributor] AAReachability : use isPotentiallyReachable in isKnownReachable

Wed Apr 15 07:05:19 PDT 2020

okura marked an inline comment as done.
okura added inline comments.

================
Comment at: llvm/test/Transforms/Attributor/noalias.ll:460
+;        Therefore, only one of the two conditions of if statementes will be fulfilled.
+; CHECK tail call void @only_store(i32* %p)
+if.then2:
----------------
jroelofs wrote:
> @okura @jdoerfert This diff added some checks with missing FileCheck colons, which silently hide the fact that these checks don't match the tool output.
> 
> Mind taking a look at this fixup patch? https://gist.github.com/jroelofs/f03ae725c6b9a5c80f9f187b80642f79
That is my terrible mistake. I am sorry and thank you for the patch.
I confirmed it passes the test and It looks good to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76210/new/

https://reviews.llvm.org/D76210