[PATCH] D78202: [FileCheck] - Refactor the code related to string arrays. NFCI.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 15 07:05:15 PDT 2020
grimar created this revision.
grimar added reviewers: jdenny, thopre, probinson, jhenderson, MaskRay.
Herald added subscribers: hiraditya, arichardson.
I've noticed that here are
few `std::vector<std::string>` members in `FileCheckRequest`,
though there is no reason not to use `StringRef` it seems.
This patch changes these arrays to `std::vector<StringRef>`
and refactors the code in callers to cleanup/improve/simplify
how it works with these arrays.
https://reviews.llvm.org/D78202
Files:
llvm/include/llvm/Support/FileCheck.h
llvm/lib/Support/FileCheck.cpp
llvm/lib/Support/FileCheckImpl.h
llvm/unittests/Support/FileCheckTest.cpp
llvm/utils/FileCheck/FileCheck.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78202.257699.patch
Type: text/x-patch
Size: 10815 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200415/67794ff9/attachment-0001.bin>
More information about the llvm-commits
mailing list