[PATCH] D78110: [LLVM/tools][test] - Remove/fix dead check prefixes.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 15 03:14:44 PDT 2020


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-symbolizer/split-dwarf.test:8
 RUN: llvm-symbolizer --functions=linkage --inlining --demangle=false \
-RUN:    --obj=%p/Inputs/split-dwarf-test 0x400504 0x4004f4 | FileCheck --check-prefix=CHECK --check-prefix=SPLIT --check-prefix=DWO %s
+RUN:    --obj=%p/Inputs/split-dwarf-test 0x400504 0x4004f4 | FileCheck --check-prefix=SPLIT --check-prefix=DWO %s
 
----------------
jhenderson wrote:
> MaskRay wrote:
> > `--check-prefixes=SPLIT,DWO`
> Do this change in all places in this file or none, I'd say, for consistency.
I'll prepare a separate cleanup change, I guess we might have the same situation in other tests and would be better to fix them at once.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78110/new/

https://reviews.llvm.org/D78110





More information about the llvm-commits mailing list