[PATCH] D78014: [AssumeBundles] Prevent generation of some redundant assumes

[Tyker via Phabricator via llvm-commits]

Tyker updated this revision to Diff 257634.
Tyker marked 3 inline comments as done.
Tyker added a comment.

addressed comments.

i ran the compile-time benchmark, the previous version of the patch had some significant slowdown but disabling tryToPreserveWithoutAddingAssume when no AssumptionCache is available brought the difference within noise levels.
the measurement was between current master and master + all the AssumeBundles patch not yet committed with knowledge retention enabled.

you are probably right that doing this on the flight isn't enought and we still need a pass to prune and regroup assume bundles.
this seems like it should be run quite often since many passes can affect assume bundles.
any thought ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78014/new/

https://reviews.llvm.org/D78014

Files:
  llvm/include/llvm/Analysis/AssumeBundleQueries.h
  llvm/include/llvm/Transforms/Utils/AssumeBundleBuilder.h
  llvm/lib/Analysis/AssumeBundleQueries.cpp
  llvm/lib/Transforms/Utils/AssumeBundleBuilder.cpp
  llvm/test/Analysis/BasicAA/featuretest.ll
  llvm/test/Transforms/EarlyCSE/guards.ll
  llvm/test/Transforms/EarlyCSE/invariant-loads.ll
  llvm/test/Transforms/Util/assume-builder.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78014.257634.patch
Type: text/x-patch
Size: 47794 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200415/4ef01502/attachment-0001.bin>