[PATCH] D78158: [ELF] Refactor the way we handle -plugin-opt= (GCC collect2 or clang LTO related options)

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.

LG with 2 minor nits.



================
Comment at: lld/ELF/Options.td:573
 
-def plugin_opt_fresolution_eq: J<"plugin-opt=-fresolution=">;
-def plugin_opt_pass_through_eq: J<"plugin-opt=-pass-through=">;
-def plugin_opt_thinlto: J<"plugin-opt=thinlto">;
-def plugin_opt_slash: J<"plugin-opt=/">;
+def plugin_opt_EQ_MINUS: J<"plugin-opt=-">,
+  HelpText<"Specify an LLVM option for compatibility with LLVMgold.so">;
----------------
Why uppercase? Seems inconsistent with: "lto_obj_path_eq", "thinlto_index_only_eq" and others.


================
Comment at: lld/ELF/Options.td:583
+// -plugin-opt=path/to/{liblto_plugin.so,lto-wrapper}
+def plugin_opt_EQ : J<"plugin-opt=">;
 
----------------
The same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78158/new/

https://reviews.llvm.org/D78158