[PATCH] D78128: Implement some functions in NativeSession.

[Pavel Labath via Phabricator via llvm-commits]

labath added a comment.

In D78128#1982184 <https://reviews.llvm.org/D78128#1982184>, @amccarth wrote:

> The load address stuff looks fine.
>
> I think the bit that tries to find the PDB file probably needs more flexibility or a bypass for the LLDB and Crash folks.  I think we should include Pavel (labath) for his opinion on that bit.  I recall there was lots of discussion about this in the Crash/Lexan meetings long ago.


If I am not mistaken the "native" PDB plugin (which is the "future" for lldb ) does not use this code path at all -- it goes directly for the llvm::pdb::***Stream classes. As such, I don't think any special hooks need to be added here. Which isn't to say that searching the CWD unconditionally is a particularly nice interface for a library, but it is pretty similar to what the llvm::DWARFContext does...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78128/new/

https://reviews.llvm.org/D78128