[PATCH] D77512: [ELF] Add --warn-backrefs-exclude=<glob>

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 15 01:02:55 PDT 2020


psmith added a comment.

Apologies for the delay in responding, just coming back from the Easter break.

- The user interface for system libraries is often --library or -l, I expect back refs from system libraries to be one of the most common exclusions as these won't be under the users control. Is it worth having --warn-backrefs-exclude mimic that interface. Perhaps even worth --warn-backrefs-exclude-searched that excludes all libraries found via --library. Maybe too blunt for many, but it may be the most common case.
- The library name might not be obvious if it is a linker script like libc that expands to several libraries. Not sure how to solve this one.
- library filenames may not be unique in some large projects, may need to add the full path to the library. If this already works maybe worth a test.

These aren't strong opinions, user interfaces aren't something I've been particular good at.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77512/new/

https://reviews.llvm.org/D77512





More information about the llvm-commits mailing list