[PATCH] D78176: [X86] Various improvements to our vector splitting helpers for lowering. NFC

[Craig Topper via Phabricator via llvm-commits]

craig.topper created this revision.
craig.topper added reviewers: RKSimon, spatel.
Herald added a subscriber: hiraditya.
Herald added a reviewer: ctetreau.
craig.topper retitled this revision from "[X86] Various improvements to our vector splitting helpers for lowering" to "[X86] Various improvements to our vector splitting helpers for lowering. NFC".
craig.topper added a child revision: D76212: [X86] Make v32i16/v64i8 legal types without avx512bw. Use custom splitting instead..

-Consistently name the functions as split*
-Add a helper for doing the two extractSubvector calls and determining the size of the split
-Use getSplitDestVTs to get the result type for the split node.
-Move the binary and unary helper to one place in the file near the extractSubvector functions. Left the VSETCC one near LowerVSETCC since that's its only caller.
-Remove the 256/512 wrappers that just had asserts. I don't think they provided a lot of value and now with the routines called split* the call sites are more obvious what they do.
-Make the unary routine support different source and dest types to support D76212 <https://reviews.llvm.org/D76212>.
-Add some weaker asserts into the helpers to make up for losing the very specific asserts from the 256/512 wrappers.


https://reviews.llvm.org/D78176

Files:
  llvm/lib/Target/X86/X86ISelLowering.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78176.257581.patch
Type: text/x-patch
Size: 15144 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200415/fe65e881/attachment-0001.bin>