[PATCH] D78166: [InlineSpiller] add assert about spills post terminators
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 14 17:58:46 PDT 2020
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM with a minor nit
================
Comment at: llvm/lib/CodeGen/InlineSpiller.cpp:949
+ // Spill are not terminators, so inserting spills after terminators will
+ // violate invariants in MachineVerifier. This is commonly observed with
+ // -verify-machineinstrs or even -verify-regalloc.
----------------
Probably don't need the "This is commonly observed with" bit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78166/new/
https://reviews.llvm.org/D78166
More information about the llvm-commits
mailing list