[PATCH] D78158: [ELF] Refactor the way we handle -plugin-opt= (GCC collect2 or clang LTO related options)

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1046
+  for (opt::Arg *arg : args.filtered(OPT_plugin_opt_EQ))
+    if (!strchr(arg->getValue(), '/'))
+      error(arg->getSpelling() + ": unknown plugin option '" + arg->getValue() +
----------------
This looks better to me. I suppose the ignore checking could be an even tighter, e.g. it contains either liblto_plugin.so or lto-wrapper - does that seem reasonable? Probably don't even need to check for '/' in that case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78158/new/

https://reviews.llvm.org/D78158