[PATCH] D78128: Implement some functions in NativeSession.

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth added a comment.

The load address stuff looks fine.

I think the bit that tries to find the PDB file probably needs more flexibility or a bypass for the LLDB and Crash folks.  I think we should include Pavel (labath) for his opinion on that bit.  I recall there was lots of discussion about this in the Crash/Lexan meetings long ago.



================
Comment at: llvm/lib/DebugInfo/PDB/Native/NativeSession.cpp:103
+    PdbPath = TmpPath;
+  }
+
----------------
I think the LLDB folks might be concerned about searching the file system for the corresponding PDB file.  The debugger folks are probably going to want a way to override that for remote debugging, symbol servers, virtual file systems, etc.

Perhaps the right thing to do is to have an API that takes paths to both the EXE and the PDB.  If everything loads, great, otherwise return an error.  Then you could have an API like this that tries to find the PDB, but rather than having it then load the session, it just forwards the PDB path to the two-path API.

That would make it possible for a client to get the automatic behavior you have here while also enabling LLDB to be explicit about where the PDB should be.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78128/new/

https://reviews.llvm.org/D78128