[PATCH] D77718: [ARM] Combines for VMOVN

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 15:45:50 PDT 2020


ctetreau marked an inline comment as done.
ctetreau added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:14316
+  // into the top or bottom lanes.
+  unsigned NumElts = N->getValueType(0).getVectorNumElements();
+  APInt Op0DemandedElts = APInt::getNullValue(NumElts);
----------------
efriedma wrote:
> ctetreau wrote:
> > getVectorNumElements is going away soon. Please do the cast.
> > 
> > See: D77278
> This is EVT::getVectorNumElements(); that's not going away, and there is no such cast.
Ahh, EVT... My old nemesis...

Please disregard.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77718/new/

https://reviews.llvm.org/D77718





More information about the llvm-commits mailing list