[PATCH] D78160: Checks for constraints C741 through C750

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld created this revision.
PeteSteinfeld added reviewers: tskeith, klausler.
Herald added a reviewer: sscalpone.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Most of these checks were already implemented, and I just added references to
them to the code and tests.  Also, much of this code was already
reviewed in the old flang/f18 GitHub repository, but I didn't get to
merge it before we switched repositories.

I implemented the check for C747 to not allow coarray components in derived
types that are of type C_PTR, C_FUNPTR, or type TEAM_TYPE.

I implemented the check for C748 that requires a data component whose type has
a coarray ultimate component to be a nonpointer, nonallocatable scalar and not
be a coarray.

I implemented the check for C750 that adds additional restrictions to the
bounds expressions of a derived type component that's an array.  C750 prohibits
specification functions, the intrinsic functions ALLOCATED, ASSOCIATED,
EXTENDS_TYPE_OF, PRESENT, and SAME_TYPE_AS.  It also requires every
specification inquiry reference to be a constant expression, and requires that
the value of the bound not not depend on the value of a variable.

I changed the implementation of IsPureProcedure() to handle statement functions
and changed some references in the code that tested for the PURE attribute to
call IsPureProcedure().

I also fixed some unrelated tests that got new errors when I implemented these
new checks.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78160

Files:
  flang/lib/Evaluate/check-expression.cpp
  flang/lib/Semantics/check-declarations.cpp
  flang/lib/Semantics/expression.cpp
  flang/lib/Semantics/resolve-names.cpp
  flang/lib/Semantics/tools.cpp
  flang/test/Semantics/allocate11.f90
  flang/test/Semantics/call10.f90
  flang/test/Semantics/call12.f90
  flang/test/Semantics/call14.f90
  flang/test/Semantics/misc-declarations.f90
  flang/test/Semantics/modfile24.f90
  flang/test/Semantics/resolve33.f90
  flang/test/Semantics/resolve44.f90
  flang/test/Semantics/resolve88.f90
  flang/test/Semantics/resolve89.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78160.257513.patch
Type: text/x-patch
Size: 23339 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200414/357ba31c/attachment.bin>