[PATCH] D74484: [AggressiveInstCombine] Add support for ICmp instr that feeds a select intsr's condition operand.

[Christopher Tetreault via Phabricator via llvm-commits]

ctetreau added inline comments.


================
Comment at: llvm/lib/Transforms/AggressiveInstCombine/TruncInstCombine.cpp:58
+  // the given type.
+  if (VT->isVectorTy()) {
+    for (unsigned i = 0; i < VT->getVectorNumElements(); i++) {
----------------
if (auto *VT = dyn_cast<VectorType>(C->getType()))


================
Comment at: llvm/lib/Transforms/AggressiveInstCombine/TruncInstCombine.cpp:59
+  if (VT->isVectorTy()) {
+    for (unsigned i = 0; i < VT->getVectorNumElements(); i++) {
+      unsigned MinCurr =
----------------
getVectorNumElements is going away soon. Please do the cast.

See: D77278

Also, is VT guaranteed to not be a scalable vector?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74484/new/

https://reviews.llvm.org/D74484