[PATCH] D78062: Adding Comment Annotations to Outlined Functions

[Jessica Paquette via Phabricator via llvm-commits]

paquette added a comment.

I think this is a better direction than before. Also, I think having the redzone attribute in the MIR is very helpful for outliner tests in general.

I think this should be two separate patches though: one to add the attribute to the MIR, and one to add comments to the outlined functions. Reason being that

1. I think that the attribute in the MIR needs a few standalone test cases
2. This is useful functionality *outside* of the outliner which I think could allow us to simplify future outliner MIR tests



================
Comment at: llvm/include/llvm/CodeGen/AsmPrinter.h:680
 
+  virtual void emitFunctionHeaderComment();
+
----------------
Might want a Doxygen comment here, so that this will have an entry in the AsmPrinter docs.

e.g.

```
/// Emits a comment for a function header.
```


================
Comment at: llvm/lib/Target/AArch64/AArch64MachineFunctionInfo.h:134
 
+  Optional<std::string> OutliningStyle;
+
----------------
This should have a Doxygen comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78062/new/

https://reviews.llvm.org/D78062