[PATCH] D78130: [SVE] Fixup calls to VectorType::getNumElements() in IR
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 14 14:39:20 PDT 2020
efriedma added a comment.
My concern with switching from getNumElements() to getElementCount() is that we're essentially adding new functionality. That new functionality should have regression test coverage. If we don't do this as we go, we're never going to get reasonable regression test coverage for scalable vectors.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78130/new/
https://reviews.llvm.org/D78130
More information about the llvm-commits
mailing list