[PATCH] D78045: [XCOFF][AIX] Fix getSymbol to return the correct qualname when necessary

[Jason Liu via Phabricator via llvm-commits]

jasonliu marked an inline comment as done.
jasonliu added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1883
+MCSymbol *
+TargetLoweringObjectFileXCOFF::getTargetSymbol(const GlobalValue *GV,
+                                               const TargetMachine &TM) const {
----------------
hubert.reinterpretcast wrote:
> I understand the current caller does not have the necessary context, but target symbols for XCOFF are not limited to the csect versus label that this currently handles. It extends to function descriptor versus entry point.
> 
> Can we use an expanded version of this function to common up the entry point referencing between `AsmPrinter::SetupMachineFunction` and the `transformCallee` that is used by `PPCTargetLowering::FinishCall`?
Relay some of the discussion from offline:
I feel adding a boolean to the parameter to determine if we need a function descriptor or entry point would make this function very XCOFF centric and complicate the interface.
I would try to add comments to make sure user of this function is clear that this function will only produce function descriptor. And in a separate patch, I will add a new function called getFunctionEntryPointSymbol to return the function entry point for every caller.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78045/new/

https://reviews.llvm.org/D78045