[PATCH] D78149: Use index for shape.to_extent_tensor

[Sean Silva via Phabricator via llvm-commits]

silvas marked an inline comment as done.
silvas added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td:184
 
-def Shape_ToExtentTensorOp : Shape_Op<"to_tensor", []> {
+def Shape_ToExtentTensorOp : Shape_Op<"to_extent_tensor", []> {
   let summary = "Creates a dimension tensor from a shape";
----------------
rriddle wrote:
> This seems to hint at a lack of coverage/usage in general.
That's exactly why I'm pushing for the TCF/TCP/npcomp stuff. Otherwise we'll always be in this awkward dance where we are incrementally adding random stuff here based on out-of-tree usage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78149/new/

https://reviews.llvm.org/D78149