[PATCH] D77187: [lld][WebAssembly] Add initial support for -Map/--print-map

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lld/test/wasm/map-file.s:27
+// CHECK:    Addr      Off     Size Out     In      Symbol
+// CHECK:       -        8        6 TYPE
+// CHECK:       -        e        5 FUNCTION
----------------
ruiu wrote:
> Hmm, what is "Off"? It looks like it is monotonically increasing, but I'm not sure what these numbers are.
These are the offset in the wasm module on disk.


================
Comment at: lld/wasm/MapFile.cpp:124-125
+  int w = 8;
+  os << right_justify("Addr", w) << ' ' << right_justify("Off", w)
+     << "     Size Out     In      Symbol\n";
+
----------------
ruiu wrote:
> Since w is always 8, you can output a plain text instead of using `right_justify`.
Good point. Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77187/new/

https://reviews.llvm.org/D77187