[PATCH] D77890: [ValueTracking] Implement canCreatePoison

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/include/llvm/Analysis/ValueTracking.h:596-597
+  /// Return true if I can create poison from non-poison operands.
+  /// If I is returning a vector value, it checks the existence of poison
+  /// element. To be specific, canCreatePoison returns true if the result can
+  /// contain poison when vectors without poison are given as operands.
----------------
This still doesn't read quite right to me. Should it be:
"For vectors, return true if there is potential poison in any element."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77890/new/

https://reviews.llvm.org/D77890