[PATCH] D74531: [WebAssembly] Emit PCH __clang_ast in custom section

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

I just landed https://reviews.llvm.org/D77115 which does similar thing for the embedded bitcode sections and should simplify this CL a little.       Although it doesn't try to do the file offset alignment.

If we can figure out way to do alignment I think that is the only remaining blocker for this.



================
Comment at: llvm/lib/MC/WasmObjectWriter.cpp:1113
+  if (Sym.getName() == "__clang_ast")
+    return false;
+
----------------
kateinoigakukun wrote:
> sbc100 wrote:
> > Why this part needed ?  What happens if you don't specify this?  I looks like removes section symbol from the symtab?
> This part prevents the clangast section symbol from putting it in symbol table.
> This part is necessary to put clangast in custom section because the sym is treated as data type but the actual content is not in data section, so WasmObjectWriter raised abortion with "data symbols must live in a data section: __clang_ast" when it tries to write the sym in symtab.
I think this part might no longer be needed after https://reviews.llvm.org/D77115



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74531/new/

https://reviews.llvm.org/D74531