[PATCH] D77986: [lit] Move llvm-test-suite result codes into llvm/lit

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 12:24:45 PDT 2020


jdoerfert added a comment.

In D77986#1981385 <https://reviews.llvm.org/D77986#1981385>, @yln wrote:

> In D77986#1980779 <https://reviews.llvm.org/D77986#1980779>, @jdenny wrote:
>
> > I don't have enough experience with lnt to know why it's worthwhile to distinguish NOEXE from FAIL, but it's not a new distinction in lnt.  If it's worthwhile there, maybe it will be worthwhile in other lit-based test suites too.
>
>
> This is the question then.  Are there plans (or a desire) to adopt this notion in other lit tests as well and should this become a supported lit feature?  Is not having these categories in "vanilla" lit blocking improvements in lnt?


To make this clear: Right now this is needed for me to run lnt with lit in the first place. Without these two patches lnt crashes as it provides lit with NOEXE result codes that are not handled in `tests_by_code` (and potentially other places).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77986/new/

https://reviews.llvm.org/D77986





More information about the llvm-commits mailing list