[PATCH] D78140: [mlir][Linalg] NFC: Add missing comments from earlier commit (D77965)

[Mahesh Ravishankar via Phabricator via llvm-commits]

mravishankar created this revision.
Herald added subscribers: llvm-commits, frgossen, grosul1, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a reviewer: nicolasvasilache.
Herald added a project: LLVM.
mravishankar added a reviewer: antiagainst.
antiagainst accepted this revision.
This revision is now accepted and ready to land.
mravishankar updated this revision to Diff 257442.
mravishankar added a comment.
mravishankar marked an inline comment as done.

Address comment.



================
Comment at: mlir/include/mlir/Dialect/Linalg/Transforms/LinalgTransforms.h:79
+
+/// Tiles ops similar to `tileAndFuseLinalgOpAndSetMarker` but generates
+/// loop.parallel operations instead.
----------------
Would be nice to explicitly mention that the previous one generates loop.for.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78140

Files:
  mlir/include/mlir/Dialect/Linalg/Transforms/LinalgTransforms.h


Index: mlir/include/mlir/Dialect/Linalg/Transforms/LinalgTransforms.h
===================================================================
--- mlir/include/mlir/Dialect/Linalg/Transforms/LinalgTransforms.h
+++ mlir/include/mlir/Dialect/Linalg/Transforms/LinalgTransforms.h
@@ -49,10 +49,10 @@
 // success.
 ////////////////////////////////////////////////////////////////////////////////
 
-/// Tiles `op` by `sizes` permuting the loops according to `permutation`
-/// and sets the attribute `kLinalgTransformMarker` to `linalgMarker`.
-/// The permutation is expressed as a list of integers that specify
-/// the new ordering of the loop nest. The length of `permutation`
+/// Tiles `op` by `sizes` permuting the loops according to `permutation` and
+/// sets the attribute `kLinalgTransformMarker` to `linalgMarker`.  The
+/// permutation is expressed as a list of integers that specify the new ordering
+/// of the loop nest (using loop.for operations). The length of `permutation`
 /// must be equal to the length of `tileSizes`.
 /// E.g. the permutation `(i,j,k) -> (j,k,i)` will be expressed with
 /// `permutation = [1,2,0]`. All values in `permutation` must be
@@ -63,6 +63,9 @@
                                        ArrayRef<int64_t> sizes,
                                        StringRef linalgMarker,
                                        ArrayRef<unsigned> permutation);
+
+/// Tiles ops similar to `tileLinalgOpAndSetMarker` but generates loop.parallel
+/// operations instead.
 LogicalResult tileLinalgOpToParallelLoopsAndSetMarker(
     PatternRewriter &rewriter, Operation *op, ArrayRef<int64_t> sizes,
     StringRef linalgMarker, ArrayRef<unsigned> permutation);
@@ -72,6 +75,9 @@
 LogicalResult tileAndFuseLinalgOpAndSetMarker(
     PatternRewriter &rewriter, Operation *op, ArrayRef<int64_t> sizes,
     ArrayRef<int64_t> operandIndicesToFuse, StringRef linalgMarker);
+
+/// Tiles ops similar to `tileAndFuseLinalgOpAndSetMarker` but generates
+/// loop.parallel operations instead.
 LogicalResult tileAndFuseLinalgOpToParallelLoopsAndSetMarker(
     PatternRewriter &rewriter, Operation *op, ArrayRef<int64_t> sizes,
     ArrayRef<int64_t> operandIndicesToFuse, StringRef linalgMarker);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78140.257442.patch
Type: text/x-patch
Size: 2215 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200414/b667639d/attachment.bin>