[PATCH] D77971: [MC][X86][NFC] Disable branch align in non-text section
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 14 11:16:28 PDT 2020
MaskRay added a comment.
In D77971#1979843 <https://reviews.llvm.org/D77971#1979843>, @skan wrote:
> And test
>
> llvm/test/MC/X86/relax-offset.s
>
> .section .text1
> .skip after-before,0x0
> .Lint80_keep_stack:
>
> .section .text2
> before:
> jmp .Lint80_keep_stack
> after:
>
>
> Section `.text1` and `.text2` are not executable, so they are not recognized as text section in LLVM, but `.text2` do contains instruction
We should not trigger `report_fatal_error` actually. See Eli's comment at https://reviews.llvm.org/D72194#1957329 I am preparing a patch to fix this particular problem.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77971/new/
https://reviews.llvm.org/D77971
More information about the llvm-commits
mailing list