[PATCH] D78045: [XCOFF][AIX] Fix getSymbol to return the correct qualname when necessary

Digger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 10:13:07 PDT 2020


DiggerLin added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1910
+  SmallString<128> NameStr;
+  TM.getNameWithPrefix(NameStr, GV, getMangler());
+  return getContext().getOrCreateSymbol(NameStr);
----------------
to be consistent with getSectionForExternalReference  and getSectionForFunctionDescriptor , I am prefer to use getNameWithPrefix(NameStr, GV, TM); here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78045/new/

https://reviews.llvm.org/D78045





More information about the llvm-commits mailing list