[PATCH] D77848: [llvm-dwarfdump] Interface cleanup. NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 09:40:32 PDT 2020


MaskRay added a comment.

In D77848#1980201 <https://reviews.llvm.org/D77848#1980201>, @jhenderson wrote:

> I'd have rejected this change, partly, if I'd seen this before the commit. I REALLY hate it when definitions and declarations for functions are not in matching header/source files. Why did the declarations relating to the SectionSizes.cpp stuff get moved into an unrelated header?


Not sure whether `SectionSizes.cpp` should be placed in its own file. Merging it into `Statistics.cpp` and adding a `Statistics.h`, does that sound good to you?

> definitions and declarations for functions are not in matching header/source files

The previous state might be worse to you? A `.cpp` file made the declarations...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77848/new/

https://reviews.llvm.org/D77848





More information about the llvm-commits mailing list