[PATCH] D78087: [MachineSink] Fix for breaking phi edges with instructions with multiple defs

[Dave Green via Phabricator via llvm-commits]

dmgreen updated this revision to Diff 257356.
dmgreen added a comment.

Thanks. I've tried to adjust the comment and changed the condition to use all_of.

With multiple defs we might end up with one def being used by phi nodes, and another not (but used/dominated by the same block). BreakPHIEdge seems to be checking for if _all_ uses are phi nodes in the same block, but I don't see a problem with only some being phis.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78087/new/

https://reviews.llvm.org/D78087

Files:
  llvm/lib/CodeGen/MachineSink.cpp
  llvm/test/CodeGen/ARM/machine-sink-multidef.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78087.257356.patch
Type: text/x-patch
Size: 4154 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200414/a66c0e2f/attachment.bin>