[PATCH] D78010: [CodeGen] Add a new parameter SkipDuplicated for copyImplicitOps()

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineInstr.cpp:1425
+    if ((MO.isReg() && MO.isImplicit()) || MO.isRegMask()) {
+      if (SkipDuplicated && (findRegisterUseOperandIdx(MO.getReg()) != -1 ||
+                             findRegisterDefOperandIdx(MO.getReg()) != -1))
----------------
nemanjai wrote:
> Won't this throw assertions on regmasks? And what should the behaviour actually be on multiple regmasks?
This O(N^2) loop over operands isn't great


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78010/new/

https://reviews.llvm.org/D78010