[PATCH] D77216: [llvm-readobj] - Fix crashes and misbehaviors when reading strings from broken string tables.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 14 05:18:13 PDT 2020
grimar added inline comments.
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2585
+ ": unable to read the string at 0x" + Twine::utohexstr(Offset + Value) +
+ ", it goes past the end of the table (0x" +
+ Twine::utohexstr(Offset + DynamicStringTable.size()) + ")",
----------------
jhenderson wrote:
> Unrelated I know, but this should be ':' not ',' for more correct grammar.
Fixed (to be consistent with new messages around).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77216/new/
https://reviews.llvm.org/D77216
More information about the llvm-commits
mailing list