[PATCH] D78010: [CodeGen] Add a new parameter SkipDuplicated for copyImplicitOps()

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D78010#1979599 <https://reviews.llvm.org/D78010#1979599>, @steven.zhang wrote:

> In D78010#1977637 <https://reviews.llvm.org/D78010#1977637>, @lebedev.ri wrote:
>
> > Passing-by remark: i feel like while the patch description really explains
> >  what is happening in this patch, it does not mention at all
> >  *why* all this is happening, why this shouldn't be happening, etc.
>
>
> For now, copyImplicitOps will blindly copy all the implicit ops no matter if we already have that implicit op. My understanding is that, we won't have any benefit if there is duplicate implicit operands. As this is a helper function to copy the implicit operands, I would suggest that, don't add a new parameter, just don't do the copy if it has. Does it make sense ?


That would make more sense to me, yes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78010/new/

https://reviews.llvm.org/D78010