[PATCH] D77718: [ARM] Combines for VMOVN

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 03:09:22 PDT 2020


samparker added inline comments.
Herald added a reviewer: ctetreau.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:14317
+  unsigned NumElts = N->getValueType(0).getVectorNumElements();
+  APInt Op0DemandedElts = APInt::getNullValue(NumElts);
+  APInt Op1DemandedElts = APInt::getNullValue(NumElts);
----------------
Would it be possible to use APInt::getSplat() instead? This is looking a bit cryptic.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77718/new/

https://reviews.llvm.org/D77718





More information about the llvm-commits mailing list