[PATCH] D77741: [FileCheck] Better diagnostic for format conflict
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 14 02:37:09 PDT 2020
jhenderson added inline comments.
================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:45
+ Error Err) {
+ auto anyErrorMsgMatch = [&ExpectedMsgs](std::string &&ErrorMsg) -> bool {
+ for (auto ExpectedMsgItr = ExpectedMsgs.begin(),
----------------
thopre wrote:
> clang-tidy complains about the first letter of this variable being lowercase but since it's a lambda I think it's justified.
I believe the general consensus is that lamdbas are variables, not functions (akin to a variable storing a function pointer or a class instance with an `operator()`), and therefore should be labelled as such with an upper-case first letter. I can dig up conversations on the topic from elsewhere if you want.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77741/new/
https://reviews.llvm.org/D77741
More information about the llvm-commits
mailing list