[PATCH] D78008: [flang] Added Semantic Checks for 5 Data Constraints
Anchu Rajendran S via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 14 01:33:25 PDT 2020
anchu-rajendran marked 2 inline comments as done.
anchu-rajendran added inline comments.
================
Comment at: flang/lib/Semantics/check-data.cpp:27-29
+ std::apply(
+ [&](const auto &... x) { (..., CheckIfConstantSubscript(x)); },
+ triplet.t);
----------------
tskeith wrote:
> I think this is clearer as:
>
> ```
> CheckIfConstantSubscript(std::get<0>(triplet.t));
> CheckIfConstantSubscript(std::get<1>(triplet.t));
> CheckIfConstantSubscript(std::get<2>(triplet.t));
>
> ```
Hi, Thank your for the comment! I have made the change suggested and fixed the formatting issues.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78008/new/
https://reviews.llvm.org/D78008
More information about the llvm-commits
mailing list