[PATCH] D77780: Remove -implicit-check-not=foo from X86/disassemble-functions.test

Tue Apr 14 01:33:22 PDT 2020

jhenderson added a comment.

In D77780#1973437 <https://reviews.llvm.org/D77780#1973437>, @xiangzhangllvm wrote:

> All things clear:
>  The test have been changed from  --implicit-check-not=**foo**  to  --implicit-check-not=**<foo>:**  last month.
>  Sorry for I didn't noticed that.
>  All my misunderstanding is base on the old check "--implicit-check-not=foo" :
>
>   Command Output (stderr):
>   --
>   command line:1:22: error: MAIN-NOT: excluded string found in input
>   -implicit-check-not='foo'
>                        ^
>   <stdin>:17:32: note: found here
>    34: e8 c7 ff ff ff callq -57 <foo>
>
>
> Thank you very much!

No problem. I don't think there's anything that needs doing here, so could you mark this review as "Abandoned" please?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77780/new/

https://reviews.llvm.org/D77780