[PATCH] D77971: [MC][X86][NFC] Disable branch align in non-text section

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 00:29:29 PDT 2020


skan added a comment.

In D77971#1979750 <https://reviews.llvm.org/D77971#1979750>, @MaskRay wrote:

> Non-text sections with instructions seem invalid cases to me, so I am not sure we need the check. If you can find a legitimate case where LLVM emits instructions, I think this patch will make sense.


llvm/test/MC/X86/reloc-bss.s

  # RUN: not --crash llvm-mc -filetype=obj -triple=x86_64-linux-gnu %s 2>&1 | FileCheck %s
  # CHECK: LLVM ERROR: cannot have fixups in virtual section!
  
  .section        .init_array,"awT", at nobits
  
  .hidden patatino
  .globl  patatino
  patatino:
    movl __init_array_start, %eax


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77971/new/

https://reviews.llvm.org/D77971





More information about the llvm-commits mailing list