[PATCH] D77554: [DWARFDebugLine] Check for (EOF) errors when parsing v5 content descriptors

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with one request.



================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/debug_line_short_prologue.s:36
+.byte   5               # DW_LNCT_MD5
+.Lshort_prologue_header_end1:
+.Lshort_prologue_end1:
----------------
labath wrote:
> jhenderson wrote:
> > Could you add a comment please, saying why this entry is considered too short?
> I've done something (maybe?) even better. One of the new cases I've added shows how the prologue would look like if it was complete.
Thanks. I didn't know that logic was even possible in assembly!


================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/debug_line_short_prologue.s:1-2
+# Test cases when we run into the end of section while parsing a line table
+# prologue.
+
----------------
Something I'm trying to encourage is using "##" for comment markers in lit tests using assembly/YAML etc, to distinguish from the RUN and CHECK lines. I find it makes them stand out better. Would you mind changing this here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77554/new/

https://reviews.llvm.org/D77554