[PATCH] D78063: Remove extra instruction left by emitRLDICWhenLoweringJumpTables
Kai Luo via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 13 21:42:42 PDT 2020
lkail added a comment.
Could you pre-commit the test case as an NFC patch so that we can see the difference?
================
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1594
+ // delete its def SrcMI. Otherwise keep it.
+ if (MRI->use_nodbg_empty(SrcReg) && !SrcMI->hasImplicitDef())
+ SrcMI->eraseFromParent();
----------------
I think it's safe to remove `!SrcMI->hasImplicitDef()` since we have known `SrcMI`'s opcode is `RLDICL` and is not a record form, should not have implicit definitions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78063/new/
https://reviews.llvm.org/D78063
More information about the llvm-commits
mailing list